Messages in this thread | | | Date | Tue, 7 Jan 2003 18:01:30 +0200 | From | Muli Ben-Yehuda <> | Subject | Re: PATCH: fix "ide_scan_direction defined but not used" in ide.c |
| |
On Tue, Jan 07, 2003 at 04:36:17PM +0000, Alan Cox wrote: > On Tue, 2003-01-07 at 13:10, Muli Ben-Yehuda wrote: > > ide_scan_drection is only used if CONFIG_BLK_DEV_IDEPCI is defined, > > giving a compilation warning otherwise. Against 2.5.54-bk. > > Please reject. This is uglier than the warning and not the right > approach
Alan, I bow to your superior knowledge and judgement. However, 'ide_scan_direction' is only used in two places in ide.c, and both of those are only compiled in if CONFIG_BLK_DEV_IDEPCI:
in ide_setup():
#ifdef CONFIG_BLK_DEV_IDEPCI if (!strcmp(s, "ide=reverse")) { ide_scan_direction = 1; printk(" : Enabled support for IDE inverse scan order.\n"); return 1; } #endif /* CONFIG_BLK_DEV_IDEPCI */
in probe_for_hwifs():
#ifdef CONFIG_BLK_DEV_IDEPCI if (pci_present()) { ide_scan_pcibus(ide_scan_direction); } #endif /* CONFIG_BLK_DEV_IDEPCI */
So protecting the variable with #ifdef .. #endif seems the simplest and least intrusive way to fix it. How would you prefer I do it? -- Muli Ben-Yehuda
my opinions may seem crazy. But they all make sense. Insane sense, but sense nontheless. -- Shlomi Fish on #offtopic.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |