Messages in this thread |  | | Date | Mon, 6 Jan 2003 10:57:01 -0800 (PST) | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] configurable LOG_BUF_SIZE |
| |
On Mon, 6 Jan 2003, Tom Rini wrote:
| On Thu, Jan 02, 2003 at 03:09:17PM -0800, Randy.Dunlap wrote: | | > This patch to 2.5.54 make LOG_BUF_LEN a configurable option. | > Actually its shift value is configurable, and that keeps it | > a power of 2. | | Erm, why not just prompt for an int, slightly change the help wording, | and then just give a default int value directly. | | Flexibility is good for everyone.
Sure, I like that, but LOG_BUF_LEN must be a power of 2 (currently) and I was trying not to rewrite that circular buffer code, that's all. However, I will if that's desirable.
And kconfig doesn't have a way to enforce the selected value...
I asked Roman about 2-3 weeks ago about some way to enforce ranges on config values, e.g. (but that wouldn't affect powers of 2).
Linus also told me that he's not crazy about this change. I just want the LOG_BUF_LEN available outside of kernel/printk.c...
-- ~Randy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |