Messages in this thread | | | From | "Andrey Panin" <> | Date | Sat, 4 Jan 2003 16:03:52 +0300 | Subject | Re: [RFC] irq handling code consolidation, second try (v850 part) |
| |
On Sat, Jan 04, 2003 at 10:00:29PM +0900, Miles Bader wrote: > Can't test it, but the v850 part looks great, ah, it's lovely to see all > that code being deleted... > > One comment: `arch_check_irq' is a bad name, it doesn't make it at all > clear what it does. > > I might suggest inverting the sense, and using `irq_valid' -- the `arch_' > prefix seems unnecessary (as with `irq_desc') since it's not a > arch-specific version of a more general wrapper.
I used arch_ prefix to clearly mark arch specifig things, but irq_valid() is probably a better name. Comments ?
-- Andrey Panin | Embedded systems software developer pazke@orbita1.ru | PGP key: wwwkeys.pgp.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |