lkml.org 
[lkml]   [2003]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.59 morse code panics
    On Thu, Jan 30, 2003 at 06:45:34PM +0000, Alan Cox wrote:

    > On Thu, 2003-01-30 at 17:36, Dave Jones wrote:
    > > As this patch further builds upon the previous one,
    > > It'd take a complete change of mind on his part to take
    > > this as it is.
    >
    > If its attached to atkbd then its not a PCism and its now
    > nicely modularised in the atkbd driver. Providing we have
    > a clear split between the core "morse sender" and the
    > platform specific morse output device (do we want
    > morse_ops 8)) it should be clean and you can write morse
    > drivers for pc speaker, for non pc keyboard and even for
    > soundblaster 8)

    It should be in the keyboard.c file, using input_event() to blink the
    LEDs. This way it'll work on all archs in 2.5.

    I will not accept it as a patch for atkbd.c, unless there is a strong
    reason to do it there.

    --
    Vojtech Pavlik
    SuSE Labs
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:3.391 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site