lkml.org 
[lkml]   [2003]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] IDE: Do not call bh_phys() on buffers with invalid b_page.
On Wed, Jan 29 2003, Benjamin Herrenschmidt wrote:
> Hi, I just spotted this in the patch (but the code itself have been
> there since 2.4.20-pre2).
>
> > - if (((unsigned long) bh->b_data) < PAGE_SIZE)
> > + if ((unsigned long) bh->b_data < PAGE_SIZE)
>
> Didn't you meant PAGE_OFFSET and not PAGE_SIZE here ? I fail to see why
> it would make any sense to compare a virtual address to PAGE_SIZE ;)

For highmem buffer heads, b_data is the offset into the page. Does look
confusing, I'll give you that :-)

The test should most likely just be removed, if anything.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.085 / U:4.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site