lkml.org 
[lkml]   [2003]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] in drivers/char/joystick/magellan.c
On Tue, 28 January 2003 16:57:19 +0100, Vojtech Pavlik wrote:
> On Tue, Jan 28, 2003 at 04:53:12PM +0100, Jörn Engel wrote:
> >
> > Without the patch below, the \0 terminating the string is written
> > anywhere. nibbles[] would be even better, I guess.
>
> Well, the zero isn't used, so it might make sense to use '0', 'A', 'B' ...
> ... though that's not very nice either.

And maintenance wins over any byte of memory. :)

> > Can you check for stupidity on my side?
>
> Can't find any. ;) Patch applied with [].

Cool!

Jörn

--
A victorious army first wins and then seeks battle.
-- Sun Tzu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.058 / U:7.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site