lkml.org 
[lkml]   [2003]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] NE PnP Update from Jeff Muizelaar (5/6)

    I've a couple of quick comments after looking over the patch:

    > -"Last modified Nov 1, 2000 by Paul Gortmaker\n";
    > +"Last modified January 20, 2003 by Jeff Muizelaar\n";

    Feel free to delete this "Last modified" stuff altogether.
    It is just extra verbage at boot we don't need. (Blame
    Jeff Garzik -- he put it there, not me... ;-)

    > + free_irq(dev->irq, dev);
    > + release_region(dev->base_addr, NE_IO_EXTENT);
    > + unregister_netdev(dev);
    > + kfree(dev->priv);
    > + kfree(dev);

    It is usually good practice to unregister a device as the
    first thing, and then release its associated resources once
    you know the kernel doesn't hold any references to it.

    Thanks,
    Paul.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:3.011 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site