lkml.org 
[lkml]   [2003]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH] new modversions implementation
On Sat, 25 Jan 2003, Sam Ravnborg wrote:

> diff -Nru a/kernel/module.c b/kernel/module.c
> --- a/kernel/module.c Sat Jan 25 12:25:07 2003
> +++ b/kernel/module.c Sat Jan 25 12:25:07 2003
>
> + kernel_gpl_symbols.num_syms = (__stop___ksymtab_gpl
> + - __start___ksymtab_gpl);
>
> The member "num_syms" says something about number of symbols,
> but is contains the syms_size. Misleading name.
> I can see this was also the case before, but confused me a bit.

Look at the definition of __{start,stop}__ksymtab and recall C pointer
arithmetics ;) (i.e. if I understood your comment right)
>
> + | $(GENKSYMS) -k $(VERSION).$(PATCHLEVEL).$(SUBLEVEL) \
> + | grep __ver \
> + | sed 's/\#define __ver_\([^ ]*\)[ ]*\([^ ]*\)/__crc_\1 =
> +0x\2 ;/g' \
>
> A genksyms replacement should do all the three steps above?

Yes, I think at some point I should take a look at patching genksyms so
that the post-processing above is not necessary anymore. However, it
doesn't hurt much, performance-wise.

> +cmd_link_multi-m = $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LDFLAGS_MODULE) -o $@
> +$(filter $(addprefix $(obj)/,$($(subst $(obj)/,,$(@:.o=-objs))) $($(subst
> +$(obj)/,,$(@:.o=-y)))),$^)
>
> The comment
> #
> # Rule to link composite objects
> #
>
> Could tell a bit more:
> #
> # Rule to link composite objects
> # Listed in kbuild makefiles with:
> # <composite object>-objs := <list of .o files>
> # or
> # <composite object>-y := <list of .o files>
> #

Sure, send a patch ;)

> +$(multi-used-m) : %.o: $(multi-objs-m) FORCE
>
> I cannot see the need for the "%.o". The "%" is not used - or have
> I misunderstood the usage of the above construction?

It's not really necessary, but it still gives a hint that we're building
.o files. It should reallyyyy be %.o: $(%-objs), only that make doesn't
like that.
> quiet_cmd_link_multi-m = LD [M] $@
> -quiet_cmd_link_single-m = LD [M] $@
> +quiet_cmd_link_module = LD [M] $@
>
> Inconsistent naming, I would like the old naming back for consistency.

No, cmd_link_module links single- and multi-part modules (.o->.ko) now,
that's why it got the more generic name.

--Kai


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [from the cache]
©2003-2011 Jasper Spaans