Messages in this thread | | | Date | Sat, 25 Jan 2003 19:28:15 -0800 | From | William Lee Irwin III <> | Subject | Re: ext2 FS corruption with 2.5.59. |
| |
On Sat, Jan 25, 2003 at 07:04:10PM -0800, Andrew Morton wrote: +static inline unsigned fr_write_begin(frlock_t *rw) +{ + unsigned ret = rw->pre_sequence++; + wmb(); + return ret; +} + +static inline unsigned fr_write_end(frlock_t *rw) +{ + unsgned ret; + wmb(); + ret = ++(rw->post_sequence); + wmb(); + return ret; +}
Ticket locks need atomic fetch and increment. These don't look right.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |