lkml.org 
[lkml]   [2003]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2.5] tg3.c: pci_{save,restore}_extended_state
    On Fri, Jan 24, 2003 at 11:53:55AM -0800, David S. Miller wrote:
    > From: "Wiedemeier, Jeff" <Jeff.Wiedemeier@hp.com>
    > Date: Fri, 24 Jan 2003 15:00:06 -0500
    >
    > The problem is that if the chip is configured for MSI (through config
    > space) and the platform's irq mapping code therefore filled in
    > pci_dev->irq with an appropriate vector for the MSI interrupt the chip
    > is assigned instead of the LSI interrupt it may also be assigned, then
    > unless MSGINT_MODE matches PCI_MSI_FLAGS_ENABLE, the driver will grab
    > wrong interrupt.
    >
    > Why isn't it enabled at the point where we save the extended state?

    It was (in config space) and that's why PCI_MSI_FLAGS_ENABLE is still
    enabled after the restore of extended state. MSGINT_MODE is a
    tigon3-specific register (not config space) and it's state does not
    follow PCI_MSI_FLAGS_ENABLE in the MSI capability.

    /jeff
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:0.020 / U:44.696 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site