lkml.org 
[lkml]   [2003]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Can't burn DVD under 2.5.59 with ide-cd
On Wed, Jan 22 2003, Joerg Schilling wrote:
> >From axboe@suse.de Wed Jan 22 09:06:12 2003
>
> >> >BURN-Free is ON.
> >> >Starting new track at sector: 0
> >> >Track 01: 4 of 4001 MB written (fifo 96%) 16.1x.cdrecord-prodvd: Success. write_g1: scsi sendcmd: no error
> >> >CDB: 2A 00 00 00 08 B8 00 00 1F 00
> >> >status: 0x1 (GOOD STATUS)
> >> >resid: 63488
> >> >cmd finished after 0.008s timeout 100s
> >>
> >> I can't tell you what happened because the kernel is broken :-(
> >>
> >> If you fix the kernel, you will get a readble error message,
>
> >How helpful. How about saying what's broken instead and I'd be happy to
> >fix it.
>
> I thought it's obvious: It is most likely a problem caused by the broken
> bit #defines in the Linux kernel for the SCSI status byte. I assume that
> status should be 0x02 instead of 0x01. In addition, I would guess that

Sounds plausible. Patch attached. Anyone care to expand on _why_ these
status bytes are shifted one bit?

===== drivers/ide/ide-cd.c 1.35 vs edited =====
--- 1.35/drivers/ide/ide-cd.c Thu Nov 21 22:56:59 2002
+++ edited/drivers/ide/ide-cd.c Wed Jan 22 09:34:28 2003
@@ -706,7 +706,7 @@
* scsi status byte
*/
if ((rq->flags & REQ_BLOCK_PC) && !rq->errors)
- rq->errors = CHECK_CONDITION;
+ rq->errors = CHECK_CONDITION << 1;

/* Check for tray open. */
if (sense_key == NOT_READY) {
--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.083 / U:2.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site