lkml.org 
[lkml]   [2003]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Simple patches for Linux as a guest OS in a plex86 VM (please consider)
Kevin Lawton <kevinlawton2001@yahoo.com> wrote:
>
> Humm, that's a good idea. I already made the mods
> to files to add an #include <asm/if.h>. That would
> be a logical place to stick such macros.

<asm/if.h> is a fine place to put the macros.

However, open-coding

#include <asm/if.h>

in the places which are known to use pushfl/popfl is fragile. Because
someone could later do something odd which results in the generation of an
unmassaged pushfl/popfl.

You need a magic bullet. Which is why I suggest including if.h via the build
system - making it truly global.

__ASSEMBLY__ and __KERNEL__ are provided via the build system as well, and
are in scope during that first inclusion. So it _should_ work....


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.075 / U:10.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site