[lkml]   [2003]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH (take 2)][2.5] hangcheck-timer
    > +#include <linux/smp_lock.h>

    not needed anymore.

    > +MODULE_AUTHOR("Joel Becker");

    What about a MODULE_DESCRIPTION()?

    > +static struct timer_list hangcheck_ticktock = {
    > + function: hangcheck_fire,
    > +};

    Use C99 initializers instead.

    > +} /* hangcheck_init() */

    These comments are a bit against the usual kernel coding style,
    espececially for that short function..

    p.s. sorry for not noticing some of the stuff earlier
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:32    [W:0.019 / U:12.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site