Messages in this thread |  | | From | "Grover, Andrew" <> | Subject | RE: [PATCH] SMP parsing rewrite, phase 1 | Date | Tue, 21 Jan 2003 10:36:46 -0800 |
| |
> From: Martin J. Bligh [mailto:mbligh@aracnet.com]
> Would be a lot easier to read if you could seperate out the > renames from the rest of the patch that actually does things. > It all makes me slightly nervous as this stuff is really easy > to break ... and it breaks wierd machines that are hard to test > for (been there, done that ;-)).
Exactly why I wanted to clean up the code - too fragile! :)
Anyways, I will take a stab at redoing the changesets the way you describe.
> +static u8 raw_phys_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = > BAD_APICID }; > > Looks odd. May have merged forward badly, that got renamed in 2.5.59 > to bios_cpu_apicid or something.
You are right. I'll fix that.
> Anyway, I'll give it a spin on my wierdo box, and see what happens.
Cool, thanks.
Regards -- Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |