Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] 2.5.54 kill module.h compiler warnings | Date | Fri, 03 Jan 2003 11:01:02 +1100 |
| |
In message <200301021557.QAA06497@harpo.it.uu.se> you write: > Rusty, > > Compiling kernel 2.5.54 with CONFIG_MODULES=n results in > tons and tons of the following warnings: > > include/linux/module.h:317: warning: statement with no effect > include/linux/module.h:353: warning: statement with no effect > > patch-2.5.54 changed *MOD_INC_USE_COUNT from macros to > __deprecated functions, but also dropped the (void) casts > in front of the try_module_get() calls. Without modules, > try_module_get() is the constant 1, hence the warnings. > > The patch below silences the warnings by adding back the > missing (void) casts. Works for me.
I know, Christoph Hellwig changed this, and I believe RTH fixed it in his merge with Linus.
Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |