lkml.org 
[lkml]   [2003]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: questions about config files, I2C and hardware sensors (2.5.59)
On Sat, 18 Jan 2003, Roman Zippel wrote:

> Hi,
>
> "Robert P. J. Day" wrote:
>
> > so the issues:
> >
> > 1) trivial: comment is wrong, there is no dependency on
> > EXPERIMENTAL
>
> This has to be answered by the I2C maintainer.
>
> > 2) since, in the sourcing Kconfig file, I2C_PROC *already* depends
> > on I2C, is there any practical value in having the dependency
> > "I2C && I2C_PROC". wouldn't "depends on I2C_PROC" be sufficient?
>
> Yes.
>
> > 3) finally, given that the comment at the top is adamant that
> > all of these options depend on I2C and I2C_PROC, wouldn't it
> > be cleaner to just make the menu itself say:
> >
> > menu "I2C HW Sensors Mainboard Support"
> > depends on I2C && I2C_PROC (or just I2C_PROC)
> > ...
> >
> > and let the internal options inherit this dependency?
>
> Yes, the menu entry needs the dependencies as well.
>
> bye, Roman

-------------------------------------------------------------------------
diff -urN linux-2.5.59/drivers/i2c/busses/Kconfig linux-new/drivers/i2c/busses/Kconfig
--- linux-2.5.59/drivers/i2c/busses/Kconfig 2003-01-17 07:13:08.000000000 -0500
+++ linux-new/drivers/i2c/busses/Kconfig 2003-01-17 07:14:58.000000000 -0500
@@ -1,13 +1,13 @@
#
# Sensor device configuration
-# All depend on EXPERIMENTAL, I2C and I2C_PROC.
+# All depend on I2C_PROC.
#

menu "I2C Hardware Sensors Mainboard support"
+ depends on I2C_PROC

config I2C_AMD756
tristate " AMD 756/766"
- depends on I2C && I2C_PROC
help
If you say yes to this option, support will be included for the AMD
756/766/768 mainboard I2C interfaces.
@@ -24,7 +24,6 @@

config I2C_AMD8111
tristate " AMD 8111"
- depends on I2C && I2C_PROC
help
If you say yes to this option, support will be included for the AMD
8111 mainboard I2C interfaces.
diff -urN linux-2.5.59/drivers/i2c/chips/Kconfig linux-new/drivers/i2c/chips/Kconfig
--- linux-2.5.59/drivers/i2c/chips/Kconfig 2003-01-17 07:13:08.000000000 -0500
+++ linux-new/drivers/i2c/chips/Kconfig 2003-01-17 07:14:58.000000000 -0500
@@ -1,13 +1,13 @@
#
# Sensor device configuration
-# All depend on EXPERIMENTAL, I2C and I2C_PROC.
+# All depend on I2C_PROC.
#

menu "I2C Hardware Sensors Chip support"
+ depends on I2C_PROC

config SENSORS_ADM1021
tristate " Analog Devices ADM1021 and compatibles"
- depends on I2C && I2C_PROC
help
If you say yes here you get support for Analog Devices ADM1021
and ADM1023 sensor chips and clones: Maxim MAX1617 and MAX1617A,
@@ -24,7 +24,6 @@

config SENSORS_LM75
tristate " National Semiconductors LM75 and compatibles"
- depends on I2C && I2C_PROC
help
If you say yes here you get support for National Semiconductor LM75
sensor chips and clones: Dallas Semi DS75 and DS1775, TelCon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.036 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site