lkml.org 
[lkml]   [2003]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH]: PPP_FILTER outbound only drops with debugging enables
Hi.

Packets in ppp_send_frame catched by pass_filter are only dropped if
debuging is enabled:

if (ppp->pass_filter.filter
&& sk_run_filter(skb, ppp->pass_filter.filter,
ppp->pass_filter.len) == 0) {
if (ppp->debug & 1) {
printk(KERN_DEBUG "PPP: outbound frame
not passed\n");
kfree_skb(skb);
return;
}
}



The problem is still present in 2.5 bitkeeper tree. Attached patch fixes it.
Regards,
Patrick

--- linux-2.4.20/drivers/net/ppp_generic.c.orig 2003-01-17 13:15:32.000000000 +0100
+++ linux-2.4.20/drivers/net/ppp_generic.c 2003-01-17 13:16:23.000000000 +0100
@@ -965,11 +965,10 @@
if (ppp->pass_filter.filter
&& sk_run_filter(skb, ppp->pass_filter.filter,
ppp->pass_filter.len) == 0) {
- if (ppp->debug & 1) {
+ if (ppp->debug & 1)
printk(KERN_DEBUG "PPP: outbound frame not passed\n");
- kfree_skb(skb);
- return;
- }
+ kfree_skb(skb);
+ return;
}
/* if this packet passes the active filter, record the time */
if (!(ppp->active_filter.filter
\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.040 / U:4.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site