lkml.org 
[lkml]   [2003]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.5] per-CPU task runqueues
Zwane Mwaikambo <zwane@holomorphy.com> wrote:
>
> This patch simply switches over to per-CPU runqueues as defined by the new
> per cpu api.
> ...
> +static DEFINE_PER_CPU(struct runqueue, runqueues);

These must be initialised to something. gcc-2.91/92 bug. There is a
build-time check for this, but it only detects the mistake if you're using a
compiler which has the bug.


Your patch works here, but I was never able to get this working when the
per-cpu areas were allocated as the CPU's come online, which is something we
kinda should work towards. This patch would need to be reverted if we try to
do that again. Which is a shame, because appreciable amounts of memory would
be saved if nr_cpus < NR_CPUS. scheduler startup is fragile..

I don't think it buys us a lot, really. These structures are so humongous
that we don't get much per-cpuness in accessing them.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.058 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site