lkml.org 
[lkml]   [2003]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: MAX_IO_APICS #ifdef'd wrongly
> I shot for the one liner that fixed the case I could test. Shoving it
> into subarch is cleaner, but needs more code movement and changes the
> prior semantics. The prior semantics were broken for larger Summit
> configurations, hmm. Maybe _all_ the array sizes should go into some
> kind of subarch analogue of param.h, e.g. mach_param.h

That sounds like the right thing to do longer-term ... let's change it
to the defn below for now, so people's trees work, then have a proper
think about to organise subarch to make this stuff work easily
(no doubt there's other gremlins there to be fixed at the same time).

M.

diff -urpN -X /home/fletch/.diff.exclude virgin/include/asm-i386/apicdef.h max_io_apics/include/asm-i386/apicdef.h
--- virgin/include/asm-i386/apicdef.h Fri Jan 17 09:18:31 2003
+++ max_io_apics/include/asm-i386/apicdef.h Fri Jan 17 16:49:41 2003
@@ -115,7 +115,7 @@

#define APIC_BASE (fix_to_virt(FIX_APIC_BASE))

-#ifdef CONFIG_X86_NUMA
+#ifdef CONFIG_NUMA
#define MAX_IO_APICS 32
#else
#define MAX_IO_APICS 8
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.041 / U:1.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site