Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] [TRIVIAL] kstrdup | Date | Wed, 15 Jan 2003 17:55:29 +1100 |
| |
In message <87bs2kkl50.fsf@goat.bogus.local> you write: > +extern void *kmemdup(const void *, __kernel_size_t, int); > + > +static inline char *kstrdup(const char *s, int flags) > + { return kmemdup(s, strlen(s) + 1, flags); } > +static inline char *strdup(const char *s) { return kstrdup(s, GFP_KERNEL); }
I disagree with this approach. (1) because strdup hides an allocation assumption: it's too dangerous an interface, (2) because introducing a new interface is a much bigger deal than consolidating existing ones.
But really, I only keep the kstrdup patch around to irritate Linus.
Thanks! Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |