lkml.org 
[lkml]   [2003]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PTRACE_GET_THREAD_AREA
> i've just seen your patch submitted to 2.5 and i think there's a mistake
> in there. this:
>
> #define GET_32BIT(desc) (((desc)->b >> 23) & 1)
>
> should be
>
> #define GET_32BIT(desc) (((desc)->b >> 22) & 1)
>
> i.e., bit 22 determines the segment bitness (default address/operand
> size), whereas bit 23 determines the granularity used to interpret the
> segment limit.

Those macros in my patch are copied directly from process.c where
get_thread_area is implemented. Since the purpose of
PTRACE_GET_THREAD_AREA is to match what get_thread_area does, it's correct
that it match.

But I think you are right that the definition is wrong. It's obviously
suspect that two things are defined using the same bit:

#define GET_32BIT(desc) (((desc)->b >> 23) & 1)
#define GET_LIMIT_PAGES(desc) (((desc)->b >> 23) & 1)

This should be fixed in both process.c and ptrace.c together.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.023 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site