lkml.org 
[lkml]   [2003]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] Consolidate vmlinux.lds.S files
From
Date
Sam Ravnborg <sam@ravnborg.org> writes:

> Recently we have seen seveal changes to arch/*/vmlinux-lds.S,
> mainly introduced by the module support but also other changes.
>
> This is first version, where I have converted i386, s390 and sparc64.
> The latter two is not tested, only to make sure it can be used by more
> than one platform.
>
> include/asm-generic/vmlinux.lds contains common definitions.
> inserted below + three diffs.
>
> i386/vmlinux.lds.S | 148 ++++++++++++++---------------------------------
> s390/vmlinux.lds.S | 138 +++++++++++++-------------------------------
> sparc64/vmlinux.lds.S | 156 +++++++++++++++++++-------------------------------
>
> 3 files changed, 149 insertions(+), 293 deletions(-)
>
> The architecture specific files became smaller.
> And adding new stuff is easier.
>
> If this the correct way of doing it - or do you have any better ways
> to do it?


You are changing the Language that vmlinux.lds.S is written in.
It appears to reduce readability by hiding information. I'm not
in favor of it.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.082 / U:2.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site