lkml.org 
[lkml]   [2003]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.56-bug
Hi Russell,
Hi LKML,

On Sun, Jan 12, 2003 at 12:15:29PM +0000, Russell King wrote:
> This patch appears not to be in 2.5.56, but applies cleanly.
>
> This patch moves BUG() and PAGE_BUG() from asm/page.h into asm/bug.h.

While we are at it: BUG() expects the offending task to be killed
so implementations, which just do a printk() there are
non-conforming.

Code paths which contain BUG() or BUG_ON() usally expect this
code-path to end and just threat the opposite condition to be
true.

A conforming implementation is panic(), if faulting is not that
easy in these architectures, but printk() is just plain wrong.

Mind to get a patch on top of your doing exactly this
modification?

Regards

Ingo Oeser
--
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.038 / U:8.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site