Messages in this thread | | | Date | Mon, 13 Jan 2003 11:09:35 -0800 | From | Greg KH <> | Subject | Re: Problems with USB |
| |
On Mon, Jan 13, 2003 at 01:59:09PM -0500, Pete Zaitcev wrote: > > On Sun, Jan 12, 2003 at 09:44:42PM +0100, Petr.Titera@whitesoft.cz wrote: > >> I have problems with USB in recent kernels (tested on 2.5.56) and > >> RedHat 8.0. Right after end of script '/etc/rc.d/rc.sysinit' and before > >> script '/etc/rc.d/rc' which runs after USB daemon khubd gets some signal > >> and ends. > > > greg k-h > > > > # USB: Fix from Jeff and Pete to keep khubd from being able to be killed > > # by a signal > > > > diff -Nru a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > > --- a/drivers/usb/core/hub.c Sun Jan 12 22:03:13 2003 > > +++ b/drivers/usb/core/hub.c Sun Jan 12 22:03:13 2003 > > @@ -1085,6 +1085,12 @@ > > > > daemonize(); > > > > + /* keep others from killing us */ > > + spin_lock_irq(¤t->sig->siglock); > > + sigemptyset(¤t->blocked); > > + recalc_sigpending(); > > + spin_unlock_irq(¤t->sig->siglock); > > + > > /* Setup a nice name */ > > strcpy(current->comm, "khubd"); > > > > For the record, I disagree with this strongly.
Ok, Arjan also just convinced me to revert this patch, as Ingo's patch is the correct fix.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |