lkml.org 
[lkml]   [2003]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: concerns about sysfs_ops

    On 13 Jan 2003, Louis Zhuang wrote:

    > Dear Mochel,
    > I found you removed off/count params in new sysfs_ops functions. That's
    > good change for show functions, but for store function, if you don't
    > give the len of data, the chained xxx_store function has to assume
    > or/and guess how long the data is. This might be a potential issue. So I
    > suggest you add 'size_t count' in store function of sysfs_ops.
    >
    > include/linux/sysfs.h: 1.21 1.22 louis 03/01/13 18:39:41 (modified,
    > needs delta)
    >
    > @@ -18,7 +18,7 @@
    >
    > struct sysfs_ops {
    > ssize_t (*show)(struct kobject *, struct attribute *,char *);
    > - ssize_t (*store)(struct kobject *,struct attribute *,const char *);
    > + ssize_t (*store)(struct kobject *,struct attribute *,const char *,
    > size_t count);
    > };

    I agree, and Linus pointed out that obvious flaw in the interface when I
    sent it to him on Friday. I'll fixing that, and should up in his tree
    later today..

    -pat

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:0.021 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site