lkml.org 
[lkml]   [2003]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: any chance of 2.6.0-test*?
Date

> But in this case, the condition was already there.. My point is that if
> you don't need a goto, you shouldn't use it. Whenever there's an
> obvious way not to use it, don't.

You should not code to avoid a construction that's valid C.
Just use the control structure that comes natural.
Of course "if (c % 2) goto a;" is a crime, but things
like "if (!buffer) goto err_out_nomem;" are better because
the tell you why the code jumps here, it includes an implicit
comment.
if (buffer) {
/* do stuff */
} else {
return -ENOMEM;
}
just obscures the logic of the code.
Or look at it another way, if you dislike goto you should
crusade against conditional return as well.

Regards
Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.148 / U:15.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site