lkml.org 
[lkml]   [2003]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] fix broken kallsyms on non-x86 archs
    Date
    From
    kallsyms is broken in parisc on 2.5.56 again because of assembler syntax 
    subtleties. This is the offending line:

    printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n"

    Note the `;' separating the two statements. On some platforms `;' is a
    comment in assembly code, and thus the following .asciz is ignored. The fix
    is attached.

    James

    ===== scripts/kallsyms.c 1.6 vs edited =====
    --- 1.6/scripts/kallsyms.c Thu Jan 2 04:02:18 2003
    +++ edited/scripts/kallsyms.c Sun Jan 12 12:23:03 2003
    @@ -144,7 +144,7 @@
    for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
    ;

    - printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
    + printf("\t.byte 0x%02x\n\t.asciz\t\"%s\"\n", k, table[i].sym + k);
    last_addr = table[i].addr;
    prev = table[i].sym;
    }
    \
     
     \ /
      Last update: 2005-03-22 13:32    [W:0.019 / U:38.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site