Messages in this thread | | | Date | Wed, 1 Jan 2003 19:30:21 +0200 (EET) | From | Marcus Alanen <> | Subject | Re: [patch, 2.5] opti92x-ad1848 one check_region fixup |
| |
On Wed, 1 Jan 2003, Jaroslav Kysela wrote:
> Your patch is bad. Lowlevel drivers allocate the hardware resources (see > snd_cs4231_create() or snd_ad1848_create() code), but these functions will > fail, because you allocate resources in the top-level code. I think that
ok, true. Rusty, I think you haven't included these opti_* patches since they depend on the "[patch, 2.5] move snd_legacy_find_free_ioport to opti92x-ad1848.c" patch; just drop the opti_* stuff if you have.
> it will be sufficient to replace check_region call with request_region and > release_resource.
This is exactly what check_region does already :), so there is no point in changing it like that.
Marcus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |