Messages in this thread |  | | Date | Wed, 04 Sep 2002 23:36:20 -0700 | From | Andrew Morton <> | Subject | Re: Race in shrink_cache |
| |
Daniel Phillips wrote: > > Hi Marcelo, > > This looks really suspicious, vmscan.c#435: > > spin_unlock(&pagemap_lru_lock); > if (put_page_testzero(page)) > __free_pages_ok(page, 0); > /* avoid to free a locked page */ > page_cache_get(page); > > /* whoops, double free coming */ > > I suggest you bump the page count before releasing the lru lock. The race > shown above may not in fact be possible, but the current code is fragile. >
That's OK. The page has a ref because of nonzero ->buffers And it is locked, which pins page->buffers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |