Messages in this thread |  | | Date | Wed, 04 Sep 2002 23:24:25 -0700 (PDT) | Subject | Re: ip_conntrack_hash() problem | From | "David S. Miller" <> |
| |
From: Patrick Schaaf <bof@bof.de> Date: Thu, 5 Sep 2002 08:21:28 +0200
B) I despise the (1 << ...htable_bits) construct, used in several places. It's nothing but obfuscation. Please reinstate ...htable_size, and use that, the code will be more readable.
You despise, but the processor doesn't. Less data loads means the code goes faster.
Franks a lot, David S. Miller davem@redhat.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |