lkml.org 
[lkml]   [2002]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: One more bio for for floppy users in 2.5.33..
On Thu, Sep 05 2002, Linus Torvalds wrote:
>
> On Thu, 5 Sep 2002, Jens Axboe wrote:
> >
> > However, I don't see how this is a two-liner change. Basically you are
> > changing bi_end_io() from a completion to partial completion invokation,
>
> Right. So we'll add one
>
> bio->bi_end_io(bio, nr_sectors)
>
> to the partial bio completion case in "finish_that_request_first()".
>
> That's one line.
>
> The other line is
>
> if (bio->bi_size) return;
>
> which has to be added to the end-request thing.
>
> (yeah, yeah, there are several end-request functions, and we need to fix
> up the function prototypes too etc, but the point is that the actual
> _work_ is just two real lines of new code).

Ah ok, then we completely agree on what needs doing :-)

And yes, this is 100% identical to the earlier bio code (I forget what
revisions, and that was prior to BK I think).

Jens

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.064 / U:2.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site