Messages in this thread |  | | Subject | Re: [reiserfs-dev] Re: [PATCH] sparc32: wrong type of nlink_t | From | Chris Mason <> | Date | 04 Sep 2002 16:29:21 -0400 |
| |
On Wed, 2002-09-04 at 16:18, Dave Kleikamp wrote: > > > Against 2.4.20-pre5 - fix up the type of nlink_t. This makes jfs and > > > reiserfs stop complaining about comparisons always turning up false > > > due to limited range of data type. > > > > > > If you change this, you change the types exported to userspace > > > which will break everything. > > > > Right. Here's a corresponding reiserfs/jfs fix, then. I've checked the > > constants aren't used for anything else except nlink overflow alerts. > > I don't like this fix. I know 32767 is a lot of links, but I don't like > artificially lowering a limit like this just because one architecture > defines nlink_t incorrectly. I'd rather get rid of the compiler warnings > with a cast in the few places the limit is checked, even though that is > a little bit ugly. >
The patch will probably cause reiserfs problems as well, we've already got people with > 32767 links on disk, going to a lower number will confuse things.
-chris
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |