Messages in this thread | | | Date | Mon, 30 Sep 2002 16:22:43 +1000 | From | David Gibson <> | Subject | Re: [Orinoco-devel] Re: Orinoco driver update |
| |
On Mon, Sep 30, 2002 at 01:37:18AM -0400, Jeff Garzik wrote: > David, > > Linus applied 0.13a and that fixes things, thanks. > > Two quick comments: > * you need pci_set_drvdata(pdev,NULL) after pci_disable_disable in your > pci_driver::remove hook
Ok, I've added that before kfree()ing the net_device structure in both orinoco_pci.c and orinoco_plx.c
> * I think it would look better to remove the struct pci_driver ->suspend > and ->resume hook references, if they are NULL (0)...
Hmm... I'd kind of prefer to leave them there, to remind me that the suspend/resume hooks need to be implemented.
-- David Gibson | For every complex problem there is a david@gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |