[lkml]   [2002]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: One more bio for for floppy users in 2.5.33..
On Tue, Sep 03 2002, Linus Torvalds wrote:
> Ok,
> I found another major bio-related bug that definitely explains why the
> floppy driver generated corruption - any partial request completion would
> be totally messed up by the BIO layer (not the floppy driver).
> Any other block device driver that did partial request completion might
> also be impacted.
> I'm still looking at the floppy driver itself - some of the request
> completion code is so messed up as to be unreadable, and some of that may
> actually be due to trying to work around the bio problem (unsuccessfully,
> I may add). So this may not actually fix things for you yet, simply
> because the floppy driver itself still does some strange things.
> Jens, oops. We should not update the counts by how much was left
> uncompleted, but by how much we successfully completed!

Yeah oops, the most embarassing thing is that Bart and I have both found
this but independently months ago but it seems it got lost at my end (or
your end, but lets not point fingers :-) :-(

Patch is ofcourse correct. I'm not sure other drivers have been hit (of
the used ones), since they would have to use old style completions and
do less than current_nr_sectors in one-go.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:28    [W:0.136 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site