Messages in this thread | | | Date | Fri, 27 Sep 2002 18:28:33 -0700 (PDT) | Subject | Re: [PATCH] IPv6: Improvement of Source Address Selection | From | "David S. Miller" <> |
| |
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> Date: Sat, 28 Sep 2002 00:17:42 +0900 (JST)
Please redesign this structure.
+struct addrselect_attrs { + struct inet6_ifaddr *ifp; + int match; + int deprecated; + int home; + int temporary; + int device; + int scope; + int label; + int matchlen; +};
This is much larger than it needs to be. Please replace these "int" binary states with single "u32 flags;" and appropriate bit definitions.
This structure sits on the stack, so it is important to be as small as we can easily make it.
Otherwise I have no problems with the patch, Alexey? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |