lkml.org 
[lkml]   [2002]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH-RFC] 4 of 4 - New problem logging macros, SCSI RAID device driver
    From
    Date
    On Tue, 2002-09-24 at 03:22, Jeff Garzik wrote:
    > If you actually want to standardize some diagnostic messages, it is a
    > huge mistake [as your scsi driver example shows] to continue to use
    > random text strings followed by a typed attribute list. If you really
    > wanted to standardize logging, why continue to allow driver authors to
    > printk driver-specific text strings in lieu of a standard string that
    > applies to the same situation in N drivers.

    A lot of it can be tidied up by very very few changes that can be done
    over time and make the job easier. Why not just start with

    dev_printk(dev, KERN_ERR "Exploded mysteriously");

    and a few notification type things people can add eg

    dev_failed(dev);
    dev_offline(dev);

    much like we keep network status. That lets driverfs tell the decision
    making code in hotplug scripts the state of play and lets it figure out
    how to reassign resources, paper over cracks, phone the engineer.

    Alan

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.022 / U:89.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site