Messages in this thread | | | Date | Wed, 25 Sep 2002 17:17:16 -0400 | From | Mark Mielke <> | Subject | Re: [PATCH][2.5] Single linked lists for Linux |
| |
On Wed, Sep 25, 2002 at 08:56:08PM +0000, Lightweight Patch Manager wrote: > +#define slist_add_front(_new, _head) \ > +do { \ > + (_new)->next = (_head); \ > + (_head) = (_new); \ > +} while (0)
I suppose it isn't a serious issue, but is it necessary to repeat '_new' and '_head' in #define?
> +/** > + * slist_del - remove an entry from list > + * @head: head to remove it from > + * @entry: entry to be removed > + */ > +#define slist_del(_head, _entry) \ > +do { \ > + (_head)->next = (_entry)->next; \ > + (_entry)->next = NULL; \ > +}
Did you miss "while (0)"?
> +#define slist_del_single(_list) \ > + (_list)->next = NULL
Perhaps an outer ()?
mark
-- mark@mielke.cc/markm@ncf.ca/markm@nortelnetworks.com __________________________ . . _ ._ . . .__ . . ._. .__ . . . .__ | Neighbourhood Coder |\/| |_| |_| |/ |_ |\/| | |_ | |/ |_ | | | | | | \ | \ |__ . | | .|. |__ |__ | \ |__ | Ottawa, Ontario, Canada
One ring to rule them all, one ring to find them, one ring to bring them all and in the darkness bind them...
http://mark.mielke.cc/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |