Messages in this thread | | | Subject | Re: 2.4.19: oops in ide-scsi | From | James Stevenson <> | Date | 25 Sep 2002 19:18:15 +0100 |
| |
Hi
then i belive there are other possible problems which may by just as bad
On Wed, 2002-09-25 at 17:46, Philippe Troin wrote: > James Stevenson <james@stev.org> writes: > > > On Tue, 2002-09-24 at 22:00, Philippe Troin wrote: > > > James Stevenson <james@stev.org> writes: > > > > > > > Hi > > > > > > > > i am glad somebody else sees the same crash as me the > > > > request Q gets set to NULL for some reson then tries to > > > > increment a stats counter in the null pointer. > > > > i know what the bug is i just dont know how to fix it :> > > > > > > I'm not sure which Q you're talking about. > > > Is that rq (in idescsi_pc_intr())? > > > > the crash happens on > > > > if (status & ERR_STAT) > > rq->errors++; > > > > because > > struct request *rq = pc->rq; > > is NULL > > Have you tried changing it to: > > if (status & ERR_STAT && rq) > rq->errors++; > > The code is going to return anyways, and rq is only used here on this > path. > > BTW, can you reproduce the oops at will? I can't :-( > > Phil.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |