lkml.org 
[lkml]   [2002]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix ide-iops for big endian archs

    On Wed, 25 Sep 2002, Benjamin Herrenschmidt wrote:
    > --- 1.1/drivers/ide/ide-iops.c Wed Sep 11 08:54:11 2002
    > +++ edited/drivers/ide/ide-iops.c Wed Sep 25 14:19:58 2002
    > @@ -54,12 +54,20 @@
    >
    > static inline void ide_insw (u32 port, void *addr, u32 count)
    > {
    > +#ifdef __BIG_ENDIAN
    > + insw(port, addr, count);
    > +#else
    > while (count--) { *(u16 *)addr = IN_WORD(port); addr += 2; }
    > +#endif

    If insw is correct on big-endian, then it sure as hell should be correct
    on little-endian. I don't understand why we wouldn't use insw on PC's,
    since it's smaller and much more traditional.

    Linus

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.026 / U:124.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site