Messages in this thread | | | Date | Fri, 20 Sep 2002 10:56:08 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH][RESEND] Cleanup (BIN|BCD)_TO_(BCD|BIN) usage/macros |
| |
Tom Rini wrote: > The other thing, is that in general people seem to expect BIN_TO_BCD(X) to > not return a value, and just convert X. Would it be better to replace > CONVERT_x to __x then ?
My gut feeling is that the users in the majority -- the ones that don't return a value -- are still abnormal. Side effects on arguments are the rare case in C, even if it is the common case here.
But to answer your question, I think s/CONVERT_x/__x/ is better than nothing...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |