Messages in this thread | | | Date | Wed, 18 Sep 2002 15:55:34 -0700 (PDT) | Subject | Re: [PATCH] Networking: send-to-self [link to non-broken patch this time] | From | "David S. Miller" <> |
| |
From: Ben Greear <greearb@candelatech.com> Date: Wed, 18 Sep 2002 00:09:50 -0700
http://www.candelatech.com/sts_2.4.19.patch
I don't think I'll be applying this:
1) No tcp ipv6 bits 2) SIOC{S,G}ACCEPTLOCALADDRS added, but no 32-bit translation code added to varions 64-bit/32-bit biarch port ioctl handling. Also, no code added to the ioctl dispatch in the networking so that devices could actually receive these requests. 3) Finally, it's just too damn ugly. If you have to ifdef it then it really doesn't belong in the tree. Maybe if the device number comparison logic changes existed via macros in tcp.h and thus removing all the CONFIG_NET_SENDTOSELF ifdefs from tcp*.c code it might be more palatable. 4) I haven't reviewed the ramifications of the route lookup changes, that is Alexey's territory.
Sorry, these changes are pretty ugly right now. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |