lkml.org 
[lkml]   [2002]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Summit patch for 2.5.34
On Thu, Sep 12, 2002 at 08:35:14PM -0700, James Cleverdon wrote:
> Patch that allows IBM x440 boxes to on-line all CPUs and interrupt routing for
> x360s. Fixed x360 ID bug.

Couple questions/comments.

- Is this the same summit code as is in 2.4-ac ?
(Ie, the one that boots on non summit systems too)
- I believe the way forward here is to work with James Bottomley,
who has a nice abstraction of the areas your patch touches for
his Voyager sub-architecture.
Linus has however been completley silent on the x86-subarch idea
despite heavyweights like Alan and Ingo adding their support...
If you go this route, James' base needs to go in first
(converting just the in-kernel visws support). After which, adding
support for Voyager, Summit and any other wacky x86esque hardware
is a simple non-intrusive patch that touches subarch specific areas.
- Some of the code you've added looks along the lines of..

if (numaq)
foo();
else if (summit)
foo2();
else
foo3();

Would it be over-abstracting to have some form of APIC struct,
defining pointers to various routines instead of lots of ugly
if's/switches/fall-through's.

However, the last point may be completley pointless after adapting to
use what James B has come up with..

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.084 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site