Messages in this thread |  | | Date | Sun, 15 Sep 2002 22:02:02 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] IRQ patch for Toshiba Char Driver in 2.5.34 |
| |
Hi!
> > > > You've just made the driver horribly racy on SMP or preempt > > > > systems.. > > > > > > Well, as long as toshiba does not make SMP notebooks, we are safe ;-). > > > > ... or preempt. Which doesn't really depend on Toshiba. > > > > Does that mean my very first kernel patch, insignificant as it is, is > probably acceptable? > > Should I resubmit it? I haven't tried 2.5.34 yet, and 2.5.33 had keyboard > problems that prevented me from using it.
Perhaps adding #ifdef CONFIG_SMP #error Not SMP safe, #ifdef CONFIG_PREEMPT #error Not preempt safe and resubmitting is not such a bad idea.
It would be nice to make it preempt/smp safe, through. [SMP notebooks are not so unreasonable; think p4 hyperthreading]. Pavel -- Casualities in World Trade Center: ~3k dead inside the building, cryptography in U.S.A. and free speech in Czech Republic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |