Messages in this thread | | | From | Lev Makhlis <> | Subject | Re: [RFC][PATCH] sard changes for 2.5.34 | Date | Sat, 14 Sep 2002 14:57:54 -0400 |
| |
> +#define MSEC(x) ((x) * 1000 / HZ)
Perhaps it would be better to report the times in ticks using jiffies_to_clock_t(), and let the userland do further conversions? The macro above has an overflow problem, it creates a counter that wraps at 2^32 / HZ (instead of 2^32), and theoretically, the userland doesn't even know what the internal HZ is. The overflow can be avoided with something like #define MSEC(x) (((x) / HZ) * 1000 + ((x) % HZ) * 1000 / HZ) but I think it would be cleaner just to change the units to ticks, especially if we're moving it to a different file and procps will need to be changed anyway. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |