Messages in this thread |  | | Date | Fri, 13 Sep 2002 09:19:20 +0200 (CEST) | From | Ingo Molnar <> | Subject | Re: [PATCH] kernel BUG at sched.c:944! only with CONFIG_PREEMPT=y] |
| |
On 12 Sep 2002, Robert Love wrote:
> > it *is* a great debugging check, at zero added cost. Scheduling from an > > atomic region *is* a critical bug that can and will cause problems in 99% > > of the cases. Rather fix the asserts that got triggered instead of backing > > out useful debugging checks ... > > There are a lot of shitty drivers that this is going to catch. [...]
of course. And your point in making it in_interrupt() had what purpose - hiding that tons of code breaks preemption? [and tons of code breaks on SMP.] Your patch was removing precisely the tool that can be used to improve SMP quality on UP boxes as well.
> [...] Yes, that is great... but we cannot BUG(). There really are a LOT > of them. In the least, we need to show_trace().
yes. And we also need kallsyms and kksymoops in the kernel, so that people can send in meaningful traces.
Ingo
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |