Messages in this thread |  | | Date | Thu, 12 Sep 2002 08:20:57 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] highmem I/O for ide-pmac.c |
| |
On Thu, Sep 12 2002, Paul Mackerras wrote: > Jens Axboe writes: > > > Doesn't look like it's needed at all, at least you never turn on highmem > > I/O with ide_toggle_bounce() :-) > > Foo, neither I do. :( > > > BTW, it would be ok to export that from ide-dma.c instead of duplicating > > it in ide-pmac. > > Looking at it again, both ide_build_sglist and ide_raw_build_sglist do > *almost* what we want. If ide-pmac used hwif->sg_table instead of > pmif->sg_table, and if ide_[raw_]build_sglist were exported and took > the maximum number of entries as a parameter instead of using the > PRD_ENTRIES constant, then ide-pmac wouldn't need to have its own > versions of those routines. Would those changes be OK?
Sounds like a perfectly fine change to me.
> Ben, any reason why we have to use pmif->sg_table rather than > hwif->sg_table?
Looks identical to me. hwif->sg_table is kmalloc'ed sg list of PRD_ENTRIES (256), pmif->sg_table is kmalloc'ed ditto of MAX_DCMDS (256) entries.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |