lkml.org 
[lkml]   [2002]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.5 Problem Status Report
    Hello!

    On Wed, Sep 11, 2002 at 12:29:26PM +0200, Jens Axboe wrote:

    > > ok I see the bug. it's due to the imbalanced nature of ide_map_buffer()
    > > vs ide_unmap_buffer(). i'll cook up a fix right away.
    > Does this make it work?

    No. It fails exactly like without the patch.

    > --- include/linux/ide.h~ 2002-09-11 12:27:14.000000000 +0200
    > +++ include/linux/ide.h 2002-09-11 12:27:29.000000000 +0200
    > @@ -597,9 +597,10 @@
    > return rq->buffer + task_rq_offset(rq);
    > }
    >
    > -extern inline void ide_unmap_buffer(char *buffer, unsigned long *flags)
    > +extern inline void ide_unmap_buffer(struct request *rq, char *buffer, unsigned long *flags)
    > {
    > - bio_kunmap_irq(buffer, flags);
    > + if (rq->bio)
    > + bio_kunmap_irq(buffer, flags);
    > }
    >
    > /*

    Perhaps you forgot to make sure rq->bio is zeroed on unmapping/freeing?

    Bye,
    Oleg
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:22    [W:0.029 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site