lkml.org 
[lkml]   [2002]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] highmem I/O for ide-pmac.c
Date
>BTW, it would be ok to export that from ide-dma.c instead of duplicating
>it in ide-pmac.

It isn't. ide-pmac doesn't use the sg_table & other DMA related
fields in HWIF, but it's own copies in the "pmif" which is a
parallel data structure.

It sucks, I know, but I have to do that with the current IDE code
as the common code would make assumption about the format of these
things and it's right to dispose them in ide_unregister.

Also, Jens is right, Paul, you never call pmac_ide_toggle_bounce()
to actually enable high IOs. Add that to the ide_dma_on/check: case,
with an if (drive->using_dma) (as enabling DMA may have failed)

Or just wait for me to finish fixing my 6xx power save on idle
stuff and I'll send an updated patch to Marcelo along with other
pmac stuffs. (I'm implementing your suggestion of comparing SRR0
content in transfer_to_handler, but so far, the comparison never
seem to match, I'll find that out soon enough though).

Ben.




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.109 / U:6.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site