Messages in this thread |  | | Date | Wed, 11 Sep 2002 20:05:02 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] highmem I/O for ide-pmac.c |
| |
On Wed, Sep 11 2002, Benjamin Herrenschmidt wrote: > >BTW, it would be ok to export that from ide-dma.c instead of duplicating > >it in ide-pmac. > > It isn't. ide-pmac doesn't use the sg_table & other DMA related > fields in HWIF, but it's own copies in the "pmif" which is a > parallel data structure.
The above refers to ide_toggle_bounce() export, pmac_* variant is exactly the same. Sorry if that wasn't clear.
> It sucks, I know, but I have to do that with the current IDE code > as the common code would make assumption about the format of these > things and it's right to dispose them in ide_unregister. > > Also, Jens is right, Paul, you never call pmac_ide_toggle_bounce() > to actually enable high IOs. Add that to the ide_dma_on/check: case, > with an if (drive->using_dma) (as enabling DMA may have failed)
Indeed
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |