[lkml]   [2002]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] highmem I/O for ide-pmac.c
On Wed, Sep 11 2002, Benjamin Herrenschmidt wrote:
> >BTW, it would be ok to export that from ide-dma.c instead of duplicating
> >it in ide-pmac.
> It isn't. ide-pmac doesn't use the sg_table & other DMA related
> fields in HWIF, but it's own copies in the "pmif" which is a
> parallel data structure.

The above refers to ide_toggle_bounce() export, pmac_* variant is
exactly the same. Sorry if that wasn't clear.

> It sucks, I know, but I have to do that with the current IDE code
> as the common code would make assumption about the format of these
> things and it's right to dispose them in ide_unregister.
> Also, Jens is right, Paul, you never call pmac_ide_toggle_bounce()
> to actually enable high IOs. Add that to the ide_dma_on/check: case,
> with an if (drive->using_dma) (as enabling DMA may have failed)


Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:28    [W:0.098 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site