lkml.org 
[lkml]   [2002]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] highmem I/O for ide-pmac.c
On Wed, Sep 11 2002, Jens Axboe wrote:
> Also, can you grow sg segments indefinitely?

Maybe you copied that from ide-dma? I think it would be safer to just
remove it, btw, there's no (if any) benefit to making the sg segments
bigger than a page since we'll much sooner hit the max sectors
limitation than the segment one.

Marcelo, please apply.

--- drivers/ide/ide-dma.c~ 2002-09-11 15:06:48.000000000 +0200
+++ drivers/ide/ide-dma.c 2002-09-11 15:07:26.000000000 +0200
@@ -268,15 +268,6 @@
struct scatterlist *sge;

/*
- * continue segment from before?
- */
- if (bh_phys(bh) == lastdataend) {
- sg[nents - 1].length += bh->b_size;
- lastdataend += bh->b_size;
- continue;
- }
-
- /*
* start new segment
*/
if (nents >= PRD_ENTRIES)
--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.109 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site